Split build.ts #562
Merged
Split build.ts #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
vicb
commented
Oct 16, 2024
| * @param nodeExternals Externals for the Node.js compilation. | ||
| * @return The configuration and the build directory. | ||
| */ | ||
| export async function compileOpenNextConfig( |
There was a problem hiding this comment.
This is an added function.
It calls the two existing function for Node and edge if needed.
The edge test has been moved to this function.
|
Thanks for your help @conico974 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make it easier to reuse code (i.e. for opennext-cloudflare).
This PR is mainly moving code around.
I'll add inline comments for other differences to make the review easier.